Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv: share type OneByOneSuite for tests related to tikv #25098

Merged
merged 36 commits into from
Jun 7, 2021
Merged

store/tikv: share type OneByOneSuite for tests related to tikv #25098

merged 36 commits into from
Jun 7, 2021

Conversation

AndreMouche
Copy link
Contributor

Signed-off-by: AndreMouche

What problem does this PR solve?

This PR removes duplicated OneByOneSuite in tikv, and shares type OneByOneSuite for those tests related to tikv.

Part of #22513

Check List

Tests

  • Unit test

Release note

  • No release note

@AndreMouche
store/tikv: share type OneByOneSuite for tests related to tikv
50d7bb0 
Signed-off-by: shirly <AndreMouche@126.com>
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 3, 2021
@AndreMouche
session/test: use tikvutil.WithTiKV instead of withTiKV
18531c2 
Signed-off-by: shirly <AndreMouche@126.com>
@AndreMouche
merge master && fix conflicts
68bb42c 
Signed-off-by: shirly <AndreMouche@126.com>
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jun 3, 2021
@AndreMouche AndreMouche added the sig/transaction SIG:Transaction label Jun 4, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 4, 2021
@youjiali1995
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 68bb42c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2021
@AndreMouche
Copy link
Contributor Author

/run-all-tests

@AndreMouche
Copy link
Contributor Author

/run-all-tests

@AndreMouche
fix ci caused by new tests
a068714 
Signed-off-by: shirly <AndreMouche@126.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2021
@AndreMouche
Copy link
Contributor Author

/merge

@zhouqiang-cl
Copy link
Contributor

/run-tics-test

@AndreMouche
Copy link
Contributor Author

/run-check_dev_2

@LittleFall
Copy link
Contributor

/run-tics-test

1 similar comment
@LittleFall
Copy link
Contributor

/run-tics-test

@LittleFall
Copy link
Contributor

/run-tics-test

1 similar comment
@LittleFall
Copy link
Contributor

/run-tics-test

@LittleFall
Copy link
Contributor

/run-tics-test

@LittleFall
Copy link
Contributor

/run-tics-test

@ti-chi-bot
Copy link
Member

@AndreMouche: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@AndreMouche
tidb/store/tikv: move withtikv to tikv/mockstore package
40ca049 
Signed-off-by: shirly <AndreMouche@126.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 7, 2021
@AndreMouche
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 40ca049

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 7, 2021
@ti-chi-bot ti-chi-bot merged commit f3e2b79 into pingcap:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

@youjiali1995 youjiali1995 youjiali1995 approved these changes

@sticnarf sticnarf Awaiting requested review from sticnarf

@andylokandy andylokandy Awaiting requested review from andylokandy

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AndreMouche @ti-chi-bot @youjiali1995 @zhouqiang-cl @LittleFall @disksing